Add Hard Voting and Median Ensembler as well as new Task Evaluator - #482
Open
Heptasphere wants to merge 3 commits into
Open
Add Hard Voting and Median Ensembler as well as new Task Evaluator#482Heptasphere wants to merge 3 commits into
Heptasphere wants to merge 3 commits into
Conversation
…rocessingTaskEvaluator.
…ple_ensembler_integration
Author
|
The code for the I considered that median is already not very popular so any other rule might remain forever unused. (That, and I'm always a bit paranoid about letting a method defined by the user be an input for anything.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR for #334.
Description of changes
Two new ensemblers and a task evaluator were added:
NoPreprocessingTaskEvaluator doesn't preprocess the base learner predictions before training / prediction, it only preprocesses the ensembler results for error estimation.
Testing
All tests are in tests/tabarena/simulation/test_ensembler.py
Basic tests for the format of the ensemblers were added. Tests for their results on a toy example were also added.
Test to check that the new task evaluator had similar results to
TaskEvaluatoron a simple ensembler (TopKAverageEnsembler) was added.log_losspreprocessing. We use the original float32 rather than the preprocessed float64, leading to aBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.