Skip to content

Stop indexing and gate messages once the epoch is sealed #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samliok wants to merge 3 commits into from
Closed

Stop indexing and gate messages once the epoch is sealed #503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b7d3c5
Stop indexing and treat all senders as non-validators once the epoch …
samliok Aug 13, 2026
5e8fbe2
remove epoch sealed check
samliok Aug 13, 2026
d9ad160
Merge branch 'main' into sealed-epoch-handling
samliok Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion simplex/epoch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func (e *Epoch) HandleMessage(msg *common.Message, from common.NodeID) error {
}

_, known := e.validatorsToPKs[string(from)]

@yacovm yacovm Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should enforce this externally, not internally.

@samliok samliok Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, should this be done in a separate pr though?

@yacovm yacovm Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if we do that in a separate PR then we don't do it here...

if !known {
if !known || e.isEpochSealed() {
e.Logger.Debug("Received message from a non-validator node", zap.Stringer("nodeID", from))
switch {
case msg.ReplicationRequest != nil && e.ReplicationEnabled:
Expand Down Expand Up @@ -1466,13 +1466,15 @@ func (e *Epoch) indexFinalizations(startRound uint64) error {
}

func (e *Epoch) indexFinalization(block common.VerifiedBlock, finalization common.Finalization) error {
// index only if the epoch is not sealed
if err := e.Storage.Index(e.finishCtx, block, finalization); err != nil {
return err
}
e.Logger.Info("Committed block",
zap.Uint64("round", finalization.Finalization.Round),
zap.Uint64("sequence", finalization.Finalization.Seq),
zap.Stringer("digest", finalization.Finalization.Digest))

e.lastBlock = &common.VerifiedFinalizedBlock{
VerifiedBlock: block,
Finalization: finalization,
Expand Down
Loading