Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #200 +/- ##
============================================
+ Coverage 91.83% 94.42% +2.58%
- Complexity 97 108 +11
============================================
Files 6 7 +1
Lines 245 269 +24
Branches 26 29 +3
============================================
+ Hits 225 254 +29
+ Misses 18 12 -6
- Partials 2 3 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why is this change being made?
pom.xml(2.2.0) and a hardcoded constant inVersionInfo(2.1.0). They had already drifted, so the SDK UserAgent header reported a stale version (AwsSecretCache/2.1.0), causing version misreporting in Secrets Manager service logs.USER_AGENT_SUFFIXon theSecretsManagerClientBuilder, discarding the upstream caller's UserAgent instead of preserving it.What is changing?
pom.xmlis now the single source of truth for the version. A Maven-filteredversion.propertiesresource (version=${project.version}) is read at runtime byVersionInfo, with a safeunknownfallback that never throws.<caller-suffix> AwsSecretCache/<version>.README.mdinstall snippet no longer hardcodes a version, it points to Maven Central.Related Links
Testing
How was this tested?
mvn clean test: BUILD SUCCESS, 46 tests, 0 failures;When testing locally, provide testing artifact(s):
Tests run: 46, Failures: 0, Errors: 0, Skipped: 0Reviewee Checklist
Update the checklist after submitting the PR
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
If not, why:
Reviewer Checklist
All reviewers please ensure the following are true before reviewing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.