fix: select popular subview across phrase batches - #42
Merged
Merged
Conversation
axisrow
force-pushed
the
ao/wordstat-25/issue-41-fix
branch
from
August 31, 2026 06:58
79671e4 to
d2db994
Compare
axisrow
force-pushed
the
ao/wordstat-25/issue-41-fix
branch
from
August 31, 2026 07:01
d2db994 to
4240b82
Compare
axisrow
commented
Aug 31, 2026
axisrow
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict
Approved / ready. I found no high-confidence correctness, security, or error-handling issue in the diff against main. The new selector reset is consistent with the phrase-batch state transition, and the metadata guard is covered for matching, mismatching, and legacy two-column exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41
Tests
ruff check src testspytest -q(188 passed before live-only run; 188 current suite)Notes
~/Downloadswere not touched.