Skip to content

fix: select popular subview across phrase batches - #42

Merged
axisrow merged 1 commit into
mainfrom
ao/wordstat-25/issue-41-fix
Aug 31, 2026
Merged

axisrow merged 1 commit into
mainfrom
ao/wordstat-25/issue-41-fix

Conversation

@axisrow

@axisrow axisrow commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • target the Popular subview instead of the shared Table parent when selecting views
  • reset to the table view after phrase changes so subview controls are present
  • fail closed when CSV metadata does not contain the requested quoted phrase

Fixes #41

Tests

  • ruff check src tests
  • pytest -q (188 passed before live-only run; 188 current suite)
  • live 3-phrase batch on Chrome :9223 with keep-raw: top headers matched each requested view and phrase

Notes

  • No basename contract was added.
  • Live CLI batch had one unrelated transient phrase-entry failure on the first phrase; the delayed live harness completed all 3 phrases and all 4 views with correct headers.
  • Chrome :9222 and ~/Downloads were not touched.

@axisrow
axisrow force-pushed the ao/wordstat-25/issue-41-fix branch from d2db994 to 4240b82 Compare August 31, 2026 07:01

@axisrow axisrow left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

Approved / ready. I found no high-confidence correctness, security, or error-handling issue in the diff against main. The new selector reset is consistent with the phrase-batch state transition, and the metadata guard is covered for matching, mismatching, and legacy two-column exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: скачанный CSV может принадлежать не тому виду — top_popular.csv с related-заголовком

1 participant