Fix time-frame seeking: T/t were identical and never accumulated (and refactor RelativeDateTime) - #297
Merged
Conversation
Both AddAssign and SubAssign stored the raw rhs into the offset, so "seek forward" behaved exactly like "seek backward" and repeated presses replaced the offset instead of compounding it. Backward now grows the always-subtracted offset, forward is its exact inverse, and absolute datetimes shift date_time directly so (date_time, offset) never combine and to_editable_string() keeps round-tripping. Fixes: #296 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The struct allowed date_time and offset to be set simultaneously, a state nothing creates since the seek fix but that to_sql_datetime_64() still had to handle and to_editable_string() silently mishandled (dropped the offset). The enum makes that state unrepresentable and removes the dead arms; RelativeDateTime::new(None/Some) callers spell the variant directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #296