docs: document font requirement and clean up clippy warnings - #2
Open
delpix7 wants to merge 3 commits into
Open
Conversation
Add an explicit Font Requirement section to the README. LATT emits Halfwidth Katakana (U+FF66-U+FF9D) plus a small Latin symbol set, but does not load or select any font itself — glyph rendering is delegated to the terminal emulator. Katana is the expected font; without a terminal font covering those glyphs the rain renders as tofu/empty squares. This is documented as a requirement for the correct visual result, not a cosmetic preference.
Add a localized comment at the KATAKANA glyph set explaining why these characters need a terminal font with Halfwidth Katakana coverage (Katana is the expected font) and that LATT delegates font selection to the terminal emulator. Documents a non-obvious dependency at the point where the characters are defined.
Fix two clippy lints in the render hot path: - needless_range_loop in step(): iterate col_active_counts with enumerate() instead of indexing by a range variable. - redundant_closure in resize(): pass Drop::new_inactive directly to map() instead of a trivial closure. No behavioral change. cargo clippy --all-targets --all-features -D warnings now passes clean.
Owner
|
well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR documents LATT's font requirement for correct visual rendering and addresses two Clippy warnings found during a small code-quality pass.
Changes
Font requirement
U+FF66–U+FF9D.KATAKANAcharacter table.Code quality
iter().enumerate()to addressneedless_range_loop.redundant_closure.Validation
The following checks pass:
cargo fmt --checkcargo checkcargo testcargo clippy --all-targets --all-features -- -D warningscargo build --releaseScope
This PR is limited to documentation of the font requirement and small Clippy-driven cleanup. It does not change LATT's rendering behavior, timing, or architecture.
Integration note
This branch modifies part of
Renderer::step(), which also changed inperf/no-per-frame-allocs.GitHub currently reports that the branches cannot be automatically merged. The expected conflict should be resolved while preserving both changes.