Skip to content

Refactor panel protocol parsing - #64

Draft
RhythrosaLabs wants to merge 1 commit into
bangcorrupt:mainfrom
RhythrosaLabs:upstream/issue-43-protocol-parsing
Draft

RhythrosaLabs wants to merge 1 commit into
bangcorrupt:mainfrom
RhythrosaLabs:upstream/issue-43-protocol-parsing

Conversation

@RhythrosaLabs

Copy link
Copy Markdown

Summary

Refactors the five-byte panel MCU parser to use typed packed packet views and a shared big-endian 32-bit decoder.

The change:

  • names the button, encoder, knob, trigger, XY, acknowledgement, and held-button packet fields
  • removes repeated raw-byte indexing and duplicated word assembly
  • preserves callback behavior and wire-format handling
  • keeps byte-order conversion explicit and portable

Resolves #43.

Validation

  • cc -std=c11 -Wall -Wextra -Werror -fsyntax-only passes with the repository firmware include paths.
  • git diff --check passes.
  • make -C cpu APP=demo is currently blocked because arm-none-eabi-gcc is not installed in the development environment.

The implementation is also published on RhythrosaLabs/freetribe-studio main as commit 78e4c4f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Protocol Parsing

1 participant