Centralize CPU interrupt channel configuration - #65
Draft
RhythrosaLabs wants to merge 1 commit into
Draft
RhythrosaLabs wants to merge 1 commit into
RhythrosaLabs wants to merge 1 commit into
Conversation
|
To be honest I think this is a bad idea considering interrupt channels can have multiple interrupts assigned to it. Im not sure but bangcorrupt might have missed this fact when assigning the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #51 by moving CPU interrupt-channel assignments into
cpu/src/kernel/config.h.The UART, SPI, clock, and systick users now reference named configuration values, so interrupt ordering can be tuned from one header without searching individual drivers.
Validation
git diff --checkpasses.arm-none-eabi-gccis not installed.This change is also published on
RhythrosaLabs/freetribe-studiomain.