Enable Dask by default for chunked indicators - #170
Conversation
There was a problem hiding this comment.
Thanks a lot @akritaag! I just suggested minor changes mainly for consistency with other files. Feel free to also update the the AUTHORS.rst and .zenodo.json if you want!
for more information, see https://pre-commit.ci
|
Thanks @baptistehamon! Applied the naming and wording suggestions in e4e77ec, and added my name under Contributors in AUTHORS.rst and .zenodo.json. Thanks for suggesting it! I made a small adjustment to the override assertion and analysis assertion: both compare against On the example test, the new example is an All 11 Dask/example tests and Ruff checks passed locally. Read the Docs and pre-commit.ci are now green too. |
|
LGTM ! Thanks again @akritaag ! |
Summary
This fixes the Dask issue from my review, following our discussion in #164.
With chunked input,
lsa.run()currently raises an error unless Dask options are passed explicitly. The two-line fix defaults chunked indicators todask="parallelized", while respecting any setting the caller provides. Dask infers the output dtype unless one is supplied, as described in xarray’s API.The supporting changes add a
lsapy[dask]install option, a chunked example, docstrings, a changelog entry, and tests for lazy execution, numerical agreement, and explicit overrides. The example also runs in a fresh Python process.Validation
Tested on Python 3.12.14, macOS arm64, with xarray 2026.7.0, Dask 2026.8.0 and NumPy 2.5.3.
docs/index.rst, which is unchanged from the base branch. Existing notebooks were rendered without execution.No performance benchmark or cross-platform test matrix was run locally.
Pull request checklist
AI assistance
OpenAI Codex was used in an agentic workflow to prepare the two-line runtime change. The supporting changes are mostly tests and documentation, plus contributor credit in AUTHORS.rst and .zenodo.json. Automated checks do not establish human review or pyOpenSci acceptance.