feat(api): open a review in a window the caller names - #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
:Diff reviewhas nowhere to say "this window". With no review already open,show_generated_diff_bufferfalls through tovim.cmd(vertical and 'vsplit' or 'split'),so an embedder handing a review off from its own buffer gets a new window and half
the rows — worst for a review map, which is the widest and longest surface here.
Solution
Export
open_review(spec, opts), takingreplace_winandlayout. Additive: thecommand passes neither, so
:Diff reviewis unchanged. Nothing is created or closed,only a named window's buffer replaced.