Skip to content

fix(base): prevent cumulative deposits from exceeding max u64 - #163

Merged
xenoliss merged 4 commits into
mainfrom
bo/fix-cumulative-deposits
Oct 30, 2025
Merged

fix(base): prevent cumulative deposits from exceeding max u64#163
xenoliss merged 4 commits into
mainfrom
bo/fix-cumulative-deposits

Conversation

@xenoliss

Copy link
Copy Markdown
Contributor
  • Add a require statement when bridging ERC20/ETH to Solana to ensure we're not exceeding the max u64 limit (changes are in src/libraries/TokenLib.sol and test/libraries/TokenLib.t.sol)
  • Format files via forge fmt

@cb-heimdall

cb-heimdall commented Oct 30, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@xenoliss
xenoliss requested a review from jackchuma October 30, 2025 09:39
@xenoliss
xenoliss merged commit 91bc07d into main Oct 30, 2025
7 checks passed
@xenoliss
xenoliss deleted the bo/fix-cumulative-deposits branch October 30, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants