fix #3908 mobiledetect/mobiledetectlib の要求バージョンを ^4.8.03 に変更 - #4523
Open
IwasakiRyuichi wants to merge 2 commits into
Open
fix #3908 mobiledetect/mobiledetectlib の要求バージョンを ^4.8.03 に変更#4523IwasakiRyuichi wants to merge 2 commits into
IwasakiRyuichi wants to merge 2 commits into
Conversation
cakephp/app の最新に合わせて 3.74.4 系から 4.x 系へ更新する。 Detection\MobileDetect の isMobile()/isTablet() は引き続き利用可能で、 既存のモバイル/タブレット判定処理に変更は不要。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ryuring
reviewed
Sep 7, 2026
レビュー指摘により、^4.8.03 だとマイナーバージョンまで自動で 上がってしまうため、パッチバージョンまでしか上がらない ~4.8.03 に変更する。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
mobiledetect/mobiledetectlibの要求バージョンを~3.74.4から^4.8.03へ変更します(cakephp/app の最新に合わせる)。対象: #3908
変更内容
composer.json/plugins/baser-core/composer.jsonのmobiledetect/mobiledetectlibを^4.8.03に変更composer updateによりcomposer.lockを更新(4.9.0 が解決されました)動作確認
Detection\MobileDetectは変わらず、config/bootstrap.phpで使用しているisMobile()/isTablet()メソッドも引き続き利用可能なことを確認済みplugins/baser-core/tests/TestCase/Utility/BcAgentTest.php、BcAbstractDetectorTest.phpが成功getcomposer.org等外部ホストへのネットワークアクセス制限)に起因するもので、本変更による回帰がないことを確認🤖 Generated with Claude Code
Generated by Claude Code