test: fix ScrollableViewport specs failing in CI - #125
Merged
Merged
Conversation
Ink's `is-in-ci` sees `CI=true` on the runner and holds every write back until unmount, so the harness read an empty stdout and each assertion got back the bare "BANNER" prefix `lastFrame` prepends. Render in debug mode, which writes whole frames regardless of CI — the same thing the shared `renderInk` helper already does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
| User | Commit | Date |
|---|---|---|
| nimrod@baz.co | test: fix ScrollableVi... | August 25, 2026 |
| blewis@hirundo.io | fix: make comment revi... | August 25, 2026 |
Contributor
|
Your organization's Advanced Security usage limit has been reached. To continue using Advanced Security reviews, please upgrade your plan or increase your usage limits in your account settings. |
gruebel
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScrollableViewportspec harness with Ink'sdebugoption. Ink'sis-in-ciseesCI=trueon the runner and holds every stdout write back until unmount, so the harness read an empty stream and each assertion got back the bare"BANNER"prefixlastFrameprepends. Debug mode writes whole frames regardless of CI — the same thing the sharedrenderInkhelper already does, which is whyReviewMenu.spec.tsxwas unaffected.Test plan
CI=true npm testpasses locally (86/86)🤖 Generated with Claude Code