Skip to content

fix: skips comments inside multiline directives - #47

Merged
gruebel merged 1 commit into
mainfrom
skip-inline-comments
Aug 30, 2026
Merged

gruebel merged 1 commit into
mainfrom
skip-inline-comments

Conversation

@gruebel

@gruebel gruebel commented Aug 29, 2026

Copy link
Copy Markdown
Member
  • also added a generic multiline directive parser helper to keep them in-sync

Fixes #45

@baz-reviewer

baz-reviewer Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Generated description

Update the Go module parser to ignore comments inside multiline directives while parsing entries. Add a shared multi parser helper for directive consistency, regression coverage, and test compilation checks.

Topics
TopicDetails
Test Validation Add a pre-commit test check that compiles workspace tests.
Modified files (1)
  • .pre-commit-config.yaml
Latest Contributors(1)
UserCommitDate
anton.gruebel@gmail.comskips comments inside ...August 29, 2026
Directive Comments Fix multiline directive parsing to skip inline comments and reuse the generic multi helper across require, exclude, replace, retract, ignore, tool, and godebug directives.
Modified files (2)
  • src/lib.rs
  • src/parser.rs
Latest Contributors(2)
UserCommitDate
anton.gruebel@gmail.comskips comments inside ...August 29, 2026
milesj@users.noreply.g...feat: Add multi-line `...June 09, 2026

Review this PR on Baz | Customize your next review

@baz-reviewer

baz-reviewer Bot commented Aug 29, 2026

Copy link
Copy Markdown

⚠️ Advanced Security cannot run on this PR.

Your organization's Advanced Security usage limit has been reached. To continue using Advanced Security reviews, please upgrade your plan or increase your usage limits in your account settings.

@baz-reviewer baz-reviewer Bot added the baz approved Baz-reviewer has approved this PR label Aug 29, 2026
@gruebel
gruebel requested a review from nimrodkor August 30, 2026 11:38
@gruebel
gruebel merged commit 03ae6d6 into main Aug 30, 2026
9 checks passed
@gruebel
gruebel deleted the skip-inline-comments branch August 30, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

baz approved Baz-reviewer has approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment-only lines inside directive blocks fail to parse

2 participants