Skip to content

test: Update BCR precommit to account for hermetic toolchain - #111

Merged
jacky8hyf merged 2 commits into
bazel-contrib:mainfrom
UebelAndre:toolchain
Sep 14, 2026
Merged

jacky8hyf merged 2 commits into
bazel-contrib:mainfrom
UebelAndre:toolchain

Conversation

@UebelAndre

Copy link
Copy Markdown
Contributor

No description provided.

@jacky8hyf jacky8hyf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message to mention the addition of 9.x bazel.

Also please mention that this (partially?) unblocks #91

@jacky8hyf jacky8hyf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the commit message should be test:, not refactor:

Also, I would even suggest to split the commit of add 9.x to be a separate change

@jacky8hyf jacky8hyf changed the title refactor: Update BCR precommit to account for hermetic toolchain test: Update BCR precommit to account for hermetic toolchain Sep 14, 2026
@jacky8hyf
jacky8hyf added this pull request to the merge queue Sep 14, 2026
Merged via the queue into bazel-contrib:main with commit 70badae Sep 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants