feat: Validate file extensions on devicetree source attributes - #118
Merged
Merged
Conversation
Replace `allow_files = True` with explicit extension allowlists so that misplaced files are rejected at analysis time instead of producing a confusing dtc failure (or, for `dtb_composite`, silently feeding a non-FDT input to fdtoverlay): devicetree_library.hdrs .dts .dtsi .dtso .h dtb.srcs .dts .dtsi .h dtbo.srcs .dtsi .dtso .h dtb_composite.base .dtb dtb_composite.overlays .dtbo
jacky8hyf
approved these changes
Sep 23, 2026
jacky8hyf
left a comment
jacky8hyf
left a comment
Collaborator
There was a problem hiding this comment.
This was written because I thought bazelbuild/bazel#10228 was the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
allow_files = Truewith explicit extension allowlists so that misplaced files are rejected at analysis time instead of producing a confusing dtc failure (or, fordtb_composite, silently feeding a non-FDT input to fdtoverlay):.dts,.dtsi,.dtso,.h.dts,.dtsi,.h.dtsi,.dtso,.h.dtb.dtbo