Enable beman-tidy v0.5.2 in default mode#286
Open
neatudarius wants to merge 3 commits into
Open
Conversation
Uncomment the beman-tidy pre-commit hook at v0.5.1 with default-mode args and add .beman-tidy.yaml. Fix requirement-level failures for readme badges, cmake library alias, and missing SPDX license IDs.
|
coverage: 95.058%. remained the same — neatudarius:enable-beman-tidy-default into bemanproject:main |
Reformat the new target_link_libraries call added for the beman::execution alias so gersemi passes in pre-commit CI.
neatudarius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beman-tidypre-commit hook at v0.5.1 in default mode (args: [".", "--verbose"], no--require-all)..beman-tidy.yamlwithignored_paths: [infra/]so the infra submodule is excluded.beman::executionalias (header-only wrapper when modules are disabled; literal alias target when modules are enabled)Closes bemanproject/beman-tidy#255 (default-mode enablement;
--require-allfollow-up tracked separately below).Initial failures (before fixes)
readme.badges[](#...)format)cmake.library_aliasbeman::executionalias in top-levelCMakeLists.txt(alias used${BEMAN_EXECUTION_TARGET_PREFIX}variable; absent entirely for non-module builds)file.license_id.pre-commit-config.yaml,.markdownlint.yaml,bin/mk-*.py,examples/suspend_never.cpp,transform_sender.hpp)Recommendations also reported (left unfixed for default mode):
release.godbolt_trunk_version— no Compiler Explorer badgereadme.title— SPDX comment precedes title linereadme.implements— uses**Implements:**instead of**Implements**:cmake.library_name— target named via${BEMAN_EXECUTION_TARGET_PREFIX}variablefile.names— 15 example/doc files use legacy naming (hyphens, not snake_case)Blockers for
--require-allreadme.title,readme.implements) and Godbolt badgecmake.library_name) and broader CMake standardization (new checks in v0.5.1:cmake.passive_projects,cmake.passive_targets,cmake.config, etc.)file.names)Test plan
pre-commit run beman-tidy --all-filespasses locally