fix(tier): lazy-load Tier.users instead of eager-loading it - #294
Merged
igorbenav merged 3 commits intoSep 13, 2026
Merged
Conversation
Collaborator
|
SQLAdmin still loaded
What I added:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tier.usersusedlazy="selectin", so every Tier load pulled in all of its users. Since most users sit in the default tier, SQLAdmin's tier pages loaded roughly the whole user table. This switches it tolazy="select", the same fix as fastroai-template#88. No migration needed.Impact (3,000 users)
User loads are unaffected:
User.tierstaysselectin.SQLAdmin
usersisn't incolumn_list).MissingGreenlcolumn by default, so SQLAdmin explicitlyselectinload`s it when you open a tier. Excluding it can be a follow-up.Changes
src/modules/tier/models.py:Tier.users→lazy="select"tests/unit/modules/tier/test_models.py: regression test lockinglazy == "select"database/models.md,admin-panel/adding-models.md,development.md): noteTier.usersas a deliberateexception to the "use
selectin" guidance