feat(FR) : add complete french translation - #548
Open
TensaZangetsu22 wants to merge 6 commits into
Open
TensaZangetsu22 wants to merge 6 commits into
TensaZangetsu22 wants to merge 6 commits into
Conversation
9.3.0 Release
Patch 9.3.1
Collaborator
|
Hi, thanks for helping us develop the Ironmon Tracker with the added language support. A few requests:
I'm happy to add this assuming the text is reasonably translated and it fits as best it can on most of the Tracker screens. As long as it doesn't distract or take away from the typical user experience when using the Tracker. |
Collaborator
|
there's currently conflicts to resolve (from the added language options in the latest release, shouldn't be too difficult to resolve) @TensaZangetsu22 in case you didn't see UTDZac's comment above, is there still more work to be done on this PR or once the conflicts are resolved is it in a state you're happy for us to review / look to merge it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am playing the Ironmon Kaizo challenge on Fire Red version for a year and a half and... I finally say "Hey it could be great if the tracker can be full translate in French" (I'm also working on a patch for the ROM at the same time... I was playing on a vanilla version all this time...)
I saw a previous PR for complete French translation but with a lot of UI issues which can affect the user experience. I created this new branch with a new PR to not affect the previous work made. I tried to fix all UI issues and stay as coherent as possible with the English version. The only thing I didn't manage to translate is the Reward names in the Stream connect menu. I made some basic tests which seems to be good but I didn't test the answer from the chat command lines available via the Stream connect option yet. I will do it in a future stream.
All your review comments will be helpful to improve this "enhancement" (it's just a translation so I don't know if we can call it an enhancement). Finally, I will finish by saying this : What a great job you did with this tracker!!! Hope this PR will help to improve it!
Best regards