Conversation
✅ Deploy Preview for htmx-extensions canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
encodeParametersbuildsobjectfrom the request's FormDataparameters, then walksObject.keys(object)to restore original types fromhx-vals/hx-vars. A key whose value serializes to nothing in FormData (an empty array, since there's nothing to push into the form data for it) never gets an entry inobjectin the first place, so that restore loop never visits it and the key is silently dropped from the JSON body.Reported against htmx core in bigskysoftware/htmx#3845, but the actual code is here: the json-enc extension's own restore step only looks at keys FormData already produced, not at the full set of keys in
hx-vals.Fix
Restore over the union of
Object.keys(object)andObject.keys(vals)instead of onlyObject.keys(object), so a key present inhx-valsbut absent from the FormData-derived object still gets added.Testing
Added
keeps hx-vals keys whose value serializes to nothing in FormData, mirroring the reporter's repro (hx-vals="js:{'firstLevel': [], 'secondLevel': {'values': []}}"). Confirmed it fails against the unmodified code (firstLevelmissing from the parsed request body) and passes after the fix. Full suite: 13/13 passing, no regressions.Closes bigskysoftware/htmx#3845