feat: add delete subcommand to remove wallet config file - #316
feat: add delete subcommand to remove wallet config file#316ayush-codes6439 wants to merge 1 commit into
Conversation
|
Hi maintainers, I have opened this PR to add the subcommand for deleting the wallet configuration file. Summary of changes:
Please review the changes when you get a chance and let me know if any updates are needed. Thanks! |
e2b9404 to
6a852be
Compare
|
Thanks for the interest! This is already covered by #312, which has been open since Aug 6 and is well into review. I'd suggest closing this one as a duplicate - better to concentrate the effort there. And review on #312 is very welcome if you'd like to join in. One thing for the future: the commit here isn't signed, and the project requires all commits to be GPG signed - worth setting that up before your next PR. |
|
Thanks for letting me know, @vadim-anfv! I'll close this PR as duplicate of #312 and will hop on to review #312 instead. Also, thanks for the heads-up regarding GPG commit signing—I'll make sure to configure GPG signing before submitting my next PR. |
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes:
Description
Adds a new subcommand to delete the stored wallet configuration file from disk.
Notes to the reviewers
This PR introduces the functionality to safely locate and remove the wallet config file when the
deletecommand is executed.Changelog notice
delete-wallet-configcommand to remove existing wallet configuration.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes: