Give the reference quadrant a landing page of cards - #330
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C79QePZ862i61EJodupwVT
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C79QePZ862i61EJodupwVT
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C79QePZ862i61EJodupwVT
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C79QePZ862i61EJodupwVT
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C79QePZ862i61EJodupwVT
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C79QePZ862i61EJodupwVT
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C79QePZ862i61EJodupwVT
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the reference quadrant's card landing page, specified in #327 (
narrative spec §3.9, amendment of 2026-09-15) and planned in #329. Executed task by task, each task reviewed on its own, then the branch reviewed as a whole.What changed
cf2bc73tests/test_docs_landing_pages.pyreads cards:CARD_SECTIONSbesideTABLE_SECTIONS,card_targets, and the API page derived by executingconf.py, since it exists only while a build runs. The same four checks now run over both shapes, and an entry that reaches outside its section with..is refused.46fe98ateph-quadrant→teph-card,teph-quadrant-icon→teph-card-icon.teph-quadrant-button, the topics page's, is untouched.c4bc9a5docs/src/_static/cards/reference/, each dark file its light file with exactly two colours swapped; the root page's dark Tutorials halo corrected from#20242bto#14181e.bfb7b65docs/src/reference/index.rstbecomes a1 2 2 2grid of seven cards with the API card leading at full width; the reference quadrant joinsCARD_SECTIONS.c070890bd69593Measured, not assumed
api-light.svgmadepixi run docs-htmlexit 2 withimage file not readable. So the specification's choice to leave icons ungated costs nothing here.:orphan:page, and an unhidden toctree each fail the check named for them.main's 2321 — 5 unit tests, 1 one-shape check, 6 one-index instances, and 4[reference]instances of the existing checks.A plan defect found by executing it
Task 4 Step 5 restored each mutation with
git checkout -- docs/src/reference/index.rst. Before that task's own commit,HEADholds the page the task replaces, so the restore would have destroyed the new page. The implementer caught it on the first mutation and restored from a saved copy; the committed page was verified byte-identical to the plan's text. The dry run done before #329 missed it because it restored withcprather than the plan's own command. The plan is corrected on this branch, which a plan still admits until its implementation merges (docs spec §3.4).Left as they are, on purpose
Three minor points from the whole-branch review, each ruled on:
card_targetswould read the last of two:link:options on one card — malformed markup nobody writes.narrative spec §3.9keeps icons ungated as presentation.Verification
On
c070890, the last commit to touch code or pages:pixi run lintevery hook passes, andpixi run docsbuilds clean with every gate passing. Onbd69593, which changes only the plan:pixi run tests2337 passed, 2 skipped, and every hook passes on the plan file.🤖 Generated with Claude Code
https://claude.ai/code/session_01C79QePZ862i61EJodupwVT