Skip to content

Fix missing SNMPv1 instance values #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoundGoof merged 1 commit into from
Jul 23, 2026
Merged

Fix missing SNMPv1 instance values #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions netsnmp/client_intf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,6 +1619,9 @@ netsnmp_get(PyObject *self, PyObject *args)
vars && (varlist_ind < varlist_len);
vars = vars->next_variable, varlist_ind++) {

if (err_ind >= 1 && varlist_ind >= err_ind - 1)
continue;

varbind = PySequence_GetItem(varlist, varlist_ind);

if (PyObject_HasAttrString(varbind, "tag")) {
Expand Down
6 changes: 6 additions & 0 deletions netsnmp/tests/system/test_errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ def test_unknown_oid_returns_no_value(self):
self.assertEqual(values, (None,))
self.assertIn(varbind.type, ('NOSUCHOBJECT', 'NOSUCHINSTANCE'))

def test_unknown_instance_returns_no_value(self):
varbind = netsnmp.Varbind(SYS_DESCR, '123')

self.assertEqual(netsnmp.snmpget(varbind, **READ_ARGS), (None,))
self.assertEqual(varbind.type, 'NOSUCHINSTANCE')

def test_read_only_set_is_rejected(self):
session = netsnmp.Session(**READ_ARGS)
varlist = netsnmp.VarList(
Expand Down
7 changes: 7 additions & 0 deletions netsnmp/tests/system/test_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ def test_get(self):
netsnmp.Varbind(SYS_DESCR, '0'), **V1_READ_ARGS)
assert_value(self, values)

def test_get_unknown_instance_returns_no_value(self):
varbind = netsnmp.Varbind(SYS_DESCR, '123')

self.assertEqual(netsnmp.snmpget(varbind, **V1_READ_ARGS), (None,))
self.assertIsNone(varbind.val)
self.assertIsNone(varbind.type)

def test_getnext(self):
values = netsnmp.snmpgetnext(
netsnmp.Varbind(SYSTEM), **V1_READ_ARGS)
Expand Down
Loading