Skip to content

Minor metrics gaps: Service port, ServiceMonitor interval, status.endpoints.metrics #101

Description

@bmorton

Low-priority cleanups found while wiring Prometheus scraping for temporal-benchmarks. None block usage (metrics on :9090 work by default), but they surprise users who customize metrics:

  1. spec.metrics.port ignored by the Service. buildMetrics() uses the configured port in listenAddress, but BuildHeadlessService/containerPorts hardcode metricsPort = 9090. Setting spec.metrics.port to a non-default value makes Temporal listen on the new port while the Service still exposes 9090, breaking ServiceMonitor scraping.

  2. spec.metrics.serviceMonitor.interval ignored. BuildServiceMonitor hardcodes interval: 30s and never reads the CRD field.

  3. status.endpoints.metrics never populated. The field is declared on EndpointsStatus but the reconciler never writes it.

Suggested fixes: thread cluster.Spec.Metrics.Port into the container/Service ports; use cluster.Spec.Metrics.ServiceMonitor.Interval (fallback 30s) in BuildServiceMonitor; populate status.endpoints.metrics during monitoring reconciliation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions