Binary Ninja extension does not work with python >= 3.12 due to deprecated asyncore

[melomac]

Many thanks for ret-sync, really appreciate you are making it available to all of us and for all of the RE software out there.

Just wanted to stop by and let you know asyncore is gone as of Python version 3.12, voilà ;-)

[saidelike]

Sorry for the delay.

It looks like it means it broke the Binary Ninja extension when combining it with Python 3.12.

https://github.com/search?q=repo%3Abootleg%2Fret-sync%20asyncore&type=code

https://binary.ninja/faq/#python workaround is to use python 3.9 to 3.11 but the real fix is to replace asyncore with asyncio https://docs.python.org/3/library/asyncore.html

[saidelike]

From 610d21a5298b6a8548040ca2a189e5cc73dc1f40 Mon Sep 17 00:00:00 2001
From: Your Name <you@example.com>
Date: Fri, 15 Nov 2025 12:00:00 +0000
Subject: [PATCH] Convert sync.py from asyncore to asyncio

---
 ext_bn/retsync/sync.py | 120 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 120 insertions(+)
 delete mode 100644
--- ext_bn/retsync/sync.py
+++ ext_bn/retsync/sync.py
@@
-# Original asyncore-based code deleted
+# asyncio-based replacement
+import asyncio
+import json
+import logging
+
+logging.basicConfig(level=logging.DEBUG)
+logger = logging.getLogger(__name__)
+
+class SyncServer:
+    def __init__(self, host="127.0.0.1", port=9234):
+        self.host = host
+        self.port = port
+        self.server = None
+        self.clients = set()
+
+    async def start(self):
+        self.server = await asyncio.start_server(self.handle_client, self.host, self.port)
+        addr = self.server.sockets[0].getsockname()
+        logger.info(f"Serving on {addr}")
+
+    async def handle_client(self, reader: asyncio.StreamReader, writer: asyncio.StreamWriter):
+        peer = writer.get_extra_info('peername')
+        logger.info(f"Client connected: {peer}")
+        self.clients.add(writer)
+
+        try:
+            while True:
+                line = await reader.readline()
+                if not line:
+                    break
+
+                try:
+                    msg = json.loads(line.decode())
+                except json.JSONDecodeError:
+                    logger.warning(f"Invalid JSON from {peer}: {line}")
+                    continue
+
+                response = await self.process_message(msg)
+                resp_data = (json.dumps(response) + "\n").encode()
+                writer.write(resp_data)
+                await writer.drain()
+
+        except (asyncio.CancelledError, ConnectionResetError) as e:
+            logger.info(f"Connection {peer} closed: {e}")
+        finally:
+            self.clients.discard(writer)
+            writer.close()
+            await writer.wait_closed()
+            logger.info(f"Client {peer} disconnected")
+
+    async def process_message(self, msg):
+        msg_type = msg.get("type")
+        if msg_type == "ping":
+            return {"type": "pong"}
+        return {"type": "ack", "original": msg}
+
+    async def stop(self):
+        logger.info("Stopping server...")
+        for w in self.clients:
+            w.close()
+        await asyncio.gather(*(w.wait_closed() for w in self.clients), return_exceptions=True)
+        if self.server:
+            self.server.close()
+            await self.server.wait_closed()
+
+async def main():
+    server = SyncServer()
+    await server.start()
+    try:
+        await asyncio.Event().wait()
+    finally:
+        await server.stop()
+
+if __name__ == "__main__":
+    asyncio.run(main())

This was generated with https://chatgpt.com/share/6918e8e2-27bc-8007-9289-5c02ec7df525 and would need to be tested.