s3proxy: skip uploading a blob the bucket already has - #923
Open
martinpitt wants to merge 1 commit into
Open
martinpitt wants to merge 1 commit into
martinpitt wants to merge 1 commit into
Conversation
The http proxy backend HEADs an object before sending it and logs "SKIP UPLOAD" when it is already there. Do the same in the S3 backend. If the object already exists, only update its timestamp so that lifecycle rules don't evict it. This avoids multiple uploads of blobs that several parallel actions produced and queued.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The http proxy backend HEADs an object before sending it and logs "SKIP UPLOAD" when it is already there. Do the same in the S3 backend. If the object already exists, only update its timestamp so that lifecycle rules don't evict it.
This avoids multiple uploads of blobs that several parallel actions produced and queued.
I tested this on a mid-sized project build: without the fix that did 278781 uploads for 60638 distinct objects, and sent 6.9 GB on the wire for 4.1 GB that got actually stored. This affects both S3 costs and also upoad time quite considerably. This is sort of the server-side counterpart to #919 (which is client-side) -- I'll look into that as well soon.
Thanks for considering!