[PERF] fix performance hit - #511
Merged
Merged
Conversation
On the cloud platform of Camptocamp, a shared redis is used to store the sessions of the different projects -> the number of keys is huge, and using an iterative match kills the performance because of the networking overhead. We switch to using redis.key(pattern), and since the pattern typically has a leading string which will allow redis to find the correct bucket, the performance should be good.
vrenaville
approved these changes
Feb 16, 2026
fsismondi
approved these changes
Feb 16, 2026
guewen
reviewed
Sep 7, 2026
| ) | ||
| except StopIteration: | ||
| # No matches found | ||
| key = f"session::{self.prefix}:{partial_sid}*" |
There was a problem hiding this comment.
Hi @gurneyalex , wondering why it is not f"{self.prefix}{partial_sid}*, as session: is already in self.prefix. Also the key generation has a quirk to pay attention to: when there is no ODOO_SESSION_REDIS_PREFIX, the key is generated as session:0424149fe72a3e5ae5bd4e3789e80401230ce219 (so no ::) and when there is one it looks like: session::foo:0424149fe72a3e5ae5bd4e3789e80401230ce219.
I'm doing a backport for 18.0 (#530) and I found that I had to change that, but that's maybe related to 19.0? About the backport, it's still in draft because I will test it live before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the cloud platform of Camptocamp, a shared redis is used to store the sessions of the different projects -> the number of keys is huge, and using an iterative match kills the performance because of the networking overhead.
We switch to using redis.key(pattern), and since the pattern typically has a leading string which will allow redis to find the correct bucket, the performance should be good.