Conversation
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5599.
Switching language with the locale switcher only called
i18n.activate()in memory — the choice was never stored anywhere. Every new tab boots throughsetUpApp, which activates the server default (or the browser language), so the new tab always came up in the default language instead of the one just selected.This stores the activated locale in
localStorageand reads it back at boot, keeping the existing precedence for first-time visitors: stored choice, thenAPP_DEFAULT_LANGUAGE, then the browser language. If storage is unavailable the app behaves exactly as before.How to test:
npx jest src/utilities/__tests__/i18nPersistence.test.jsinfrontend— 4 tests, all fail without the fix and pass with it.i18n.configmodule: before the fix the second tab readnull, after the fix it readsfr.src/utilities+LocaleSwitchersuites (27 tests) still pass.