fix(api|frontend): improve access controls for creating/updating domains with restricted fields - #7583
Open
lcampbell2 wants to merge 3 commits into
Open
fix(api|frontend): improve access controls for creating/updating domains with restricted fields#7583lcampbell2 wants to merge 3 commits into
lcampbell2 wants to merge 3 commits into
Conversation
lcampbell2
commented
Sep 15, 2026
Collaborator
- Fix broken RBAC on domain archived/ignoreRua/highAvailability fields: admins could set them on create/update despite access-control.js declaring them super-admin-only, because nothing actually consulted the grant's attrs.
- Add auth.getDeniedFields (api/src/auth/utils/get-denied-fields.js), which uses accesscontrol's own Permission.filter() against the existing grant definitions to detect denied fields, replacing a hand-maintained field list duplicated in both mutations. Wired into context.auth in create-context.js.
- create-domain.js/update-domain.js now call this shared check instead of ad hoc per-field logic (previously only highAvailability was checked on create at all).
- AdminDomainModal.js: only include these fields in createDomain/updateDomain mutation variables when the acting user is super_admin, so non-super-admins no longer trip the new 403 just by submitting an unrelated edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.