cleanup after modular ships: remove old code duplication, and new temporary stuff - #83
Merged
Conversation
ccp-intern
commented
Sep 2, 2026
ccp-intern
commented
Member
- Remove running damage locator filtering for layout ships.
- Granny res and geometry res had duplicated triangle intersection code. Geometry res uses IntersectTri, which has been optimized as part of modular ship work. So make granny res use that function as well, and remove the old duplicate.
filipppavlov
approved these changes
Sep 2, 2026
ccp-intern
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.