fix python 2 iteritems() to use items() part of python3 migration - #84
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, clearly scoped to Python 3 compatibility, and does not introduce behavioral changes beyond replacing a Python 2-only API.
Pull request overview
Updates the shader compiler Python wrapper to be Python 3–compatible by removing a Python 2-only dictionary iteration API, with a couple of minor formatting-only adjustments.
Changes:
- Replace
(defines or {}).iteritems()with(defines or {}).items()for Python 3 compatibility. - Reformat long
os.path.join(...)/os.path.abspath(...)lines for readability (no functional change).
File summaries
| File | Description |
|---|---|
shadercompiler/python/shadercompiler/compiler.py |
Python 3 migration fix for dict iteration in compile_shader; minor line wrapping/spacing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
filipppavlov
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python3 regression tests in teamcity flag this as iteritems() as outdated and item() should be used instead