Feature/sharding - #293
Feature/sharding#293michalpalkowski wants to merge 2 commits into
Conversation
|
@michalpalkowski is attempting to deploy a commit to the cartridge Team on Vercel. A member of the Team first needs to authorize it. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ff33eab63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| description = "Dojo achievement library" | ||
| homepage = "https://github.com/cartridge-gg/arcade/" | ||
| cairo-version = "2.12.2" | ||
| cairo-version = "2.13.1" |
There was a problem hiding this comment.
Setting cairo-version to 2.13.1 here makes the repo require a newer Cairo/Scarb toolchain, but CI is still pinned to scarb-version: "2.12.2" in .github/workflows/ci.yml (checked lines 30-33, 54-57, and 70-73), and local tooling is still pinned in .tool-versions. This mismatch will cause build/test jobs (and developers using the pinned tool versions) to fail on version resolution before compilation, so the toolchain pins need to be bumped in the same change.
Useful? React with 👍 / 👎.
1 participant
No description provided.