fix(keychain): route card purchases through credits - #2661
Merged
Merged
Conversation
![cartridge-agent[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
==========================================
+ Coverage 23.68% 28.78% +5.09%
==========================================
Files 352 378 +26
Lines 42485 48052 +5567
Branches 1370 2089 +719
==========================================
+ Hits 10064 13831 +3767
- Misses 32398 34179 +1781
- Partials 23 42 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults to the Credits rail whenever the existing balance covers the starter-pack purchase, even when Credit Card was previously remembered. When credits are insufficient and Credit Card is selected, routes through the existing credits deposit flow and automatically resumes the bundle purchase after settlement. Replaces the direct Coinflow starter-pack total with the authoritative credits quote and renders the payment unit as USD, with regression coverage for preference resolution, card routing, shortfall rounding, and minimum deposits.
This replacement uses a shorter branch name so the Next.js preview can embed the matching keychain preview iframe directly without Vercel truncating each project alias to a different hash. Validated with keychain lint, formatting, production build, 757 passing tests, and a Playwright-rendered Storybook check; the repository-wide pre-commit build's live GraphQL codegen timed out against
api.cartridge.gg, so the commits used the already validated checked-in generated schema.Prompted by: tarrence