Skip to content

Proposal: Write styles in CSS and import during build #103

Description

@BrianSipple

In order to get our table styling, users currently have to place imports at the top of their app.scss file:

@import "justa-table/justa-table-structure";
@import "justa-table/justa-table-appearance";

This means that our styles won't work for projects using PostCSS, Stylus, or just CSS. A more robust approach would be to write our styles in CSS, and then use the addon's included hook in index.js to take care of importing the styles into a consuming project. Two birds with one stone.

I outlined a such an approach in a recent blog post (shameless plug 😛 ), and I'd love to help implement this here if it that sounds like an agreeable strategy.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions