Skip to content

Be able to turn off instances in password-instances (#65) - #89

Merged
Vlix merged 1 commit into
cdepillabout:masterfrom
blackheaven:refactor/flag-password-instances
Apr 10, 2026
Merged

Be able to turn off instances in password-instances (#65)#89
Vlix merged 1 commit into
cdepillabout:masterfrom
blackheaven:refactor/flag-password-instances

Conversation

@blackheaven

Copy link
Copy Markdown
Contributor

To be merged after #87

@Vlix

Vlix commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

Looks good 💯 thanks for the PR! Will merge after #87 👌

Though please add a link to this PR and your credits to the Changelog in password-instances. Just like the other ones.

Oh! And also add an entry that since version 3.1.0.0 the password-instances package has been split up and now re-exports all instances from the split packages. 🙏

@blackheaven
blackheaven force-pushed the refactor/flag-password-instances branch from 08997e9 to 81594c9 Compare October 7, 2025 20:22
@Vlix Vlix mentioned this pull request Oct 12, 2025
22 tasks
@Vlix

Vlix commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Ok, we've finally moved forward with #87.
@blackheaven, could you rebase and fix any conflicts to prep this PR for merging? 🙏

@blackheaven
blackheaven force-pushed the refactor/flag-password-instances branch from 81594c9 to f8086c6 Compare April 6, 2026 20:24
@blackheaven

Copy link
Copy Markdown
Contributor Author

Here we go, thanks for having a look at it.

@blackheaven
blackheaven marked this pull request as ready for review April 6, 2026 20:25
name: password-instances
version: 3.0.0.0
category: Security
version: 3.0.1.0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now 2 version and category fields 😅 (please drop the Data category)

While you fix this, maybe also change the version to 3.1.0.0 (and also in the Changelog)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge fail!

Done, thanks!

@blackheaven
blackheaven force-pushed the refactor/flag-password-instances branch from f8086c6 to ade7393 Compare April 8, 2026 18:19
@blackheaven
blackheaven requested a review from Vlix April 8, 2026 18:19
@Vlix
Vlix merged commit 072f2bd into cdepillabout:master Apr 10, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants