Alternate lr proposal - #91
Merged
Merged
Conversation
…g rates per-parameter
Pengju-Sheng
marked this pull request as ready for review
July 24, 2026 12:17
Pengju-Sheng
approved these changes
Jul 24, 2026
Pengju-Sheng
left a comment
Pengju-Sheng
left a comment
Collaborator
There was a problem hiding this comment.
Looks very reasonable to me.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative idea to #90 - not sure if it makes more sense to make a different PR to compare or to submit a PR to that branch, we'll try this for now.