docs(minipay): collapse the section to one Celo-specific overview that routes to docs.minipay.xyz - #2271
Open
GigaHierz wants to merge 3 commits into
Open
docs(minipay): collapse the section to one Celo-specific overview that routes to docs.minipay.xyz#2271GigaHierz wants to merge 3 commits into
GigaHierz wants to merge 3 commits into
Conversation
…t routes to docs.minipay.xyz Refs #2264 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
7 tasks
…has no stableTokenABI export) Refs #2264 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ished @celo/identity API The carried-over snippet used a viem sign191 signer and a CELO_SEPOLIA context that do not exist in @celo/identity 5.x. Use the DEK (ENCRYPTION_KEY) signer, the mainnet context, and a viem readContract call with the FederatedAttestations ABI from @celo/abis. Refs #2264 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hole, and the fix
build-on-celo/build-on-minipay/had five pages (overview, quickstart, code-library, deeplinks, ngrok-setup) that duplicated — and lagged — the MiniPay team's own docs, and none of the five linked to docs.minipay.xyz. Two copies of the mini-app lifecycle is two copies to keep fresh.This PR collapses the section to one page,
build-on-celo/build-on-minipay/overview.mdx, that keeps only what is Celo-specific and routes everything else out:eth_estimateGas/eth_gasPrice+feeCurrencysnippetwindow.ethereum.isMiniPaydetection and auto-connectcode-library#resolve-minipay-phone-numbers-to-addresses; the redirect plus the identical heading keeps that anchor workingDeleted: the other 4 pages and the 26 screenshots only they referenced. Redirects: the 4 deleted paths, plus the 6 legacy
/developer/build-on-minipay/*entries that pointed at/build/build-on-minipay/*(paths that have no page and relied on the/build/:slug*catch-all), now all point directly at the overview; 6/build/build-on-minipay/*sources added for the same reason. 3 inbound links (composer-kit.mdx,quickstart.mdx,wallets/index.mdx) updated from the stale/build/...paths to the real one.What this does NOT do / residual risk
.htmlURLs their site serves (VitePress); if they turn on clean URLs those still resolve, but the links are outside ourmint broken-linksgate — 29 of them were curled today, all 200.@celo/identityhas no Celo Sepolia context, so the page says mainnet only; whether ODIS is deployed on Celo Sepolia is OPEN.quickstartorcode-library(other than the phone-lookup anchor) now land on the overview top.Judgement calls
Issues
Refs #2264 — closes: one overview page; 4 pages deleted with redirects;
docs.json:1795–1816redirects re-pointed; Celo-specific troubleshooting snippets kept; in place (no directory move); broken-links green. Still open: the ops box (inform the MiniPay docs owners which slugs we deep-link to); "written to AGENTS.md" is met in substance (sentence-case headings, Prerequisites → task sections → Related, bare fence tags) but AGENTS.md itself is in #2269, unmerged.Stacking / conflicts
Branched off
main, independent of my other open PRs. Sharesdocs.jsonwith #2267 (top-levelintegrationsblock) and #2270 (Build with AI sub-groups) — different hunks, no conflict; merge in any order.Verification evidence
TypeScript (
tsc --noEmit --strict):First run failed:— carried over from the deleted code-library page; fixed by using viem'sModule '"@celo/abis"' has no exported member 'stableTokenABI'erc20Abi.Second run: the ODIS snippet typechecks— it did not:sign191is not a member ofWalletKeySignerandOdisContextName.CELO_SEPOLIAdoes not exist in@celo/identity5.1.2 (the old page's snippet never matched the released API). Rewritten in9d62403fto use the DEKENCRYPTION_KEYsigner, the mainnet ODIS context, andreadContractwithfederatedAttestationsABIfrom@celo/abis. Third run, snippet extracted verbatim from the page:Contract addresses in that snippet were resolved from the on-chain registry (
0x…ce10getAddressForString): FederatedAttestations0x0aD5…aff2, OdisPayments0xAE6B…D0CB, matchingtooling/contracts/core-contracts.mdx.External: all 29 docs.minipay.xyz URLs, the MiniPay template repo, the faucet, the Mento app and celopg.eco returned 200 on 2026-08-21;
celopg.eco/programs/proof-of-ship-s1(old link) returned 404.Remaining ops steps
docs.celo.org/developer/build-on-minipay/code-library#resolve-minipay-phone-numbers-to-addressesnow redirects to the overview with the same anchorChecklist
mainmint broken-linkspasses; redirects added for every deleted path (listed above)