Complete jq semantics and make evaluation allocation-aware - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The evaluator accepted only part of jq's expression grammar, diverged on several streaming/numeric/error cases, and deep-copied pass-through values at every coroutine boundary.
std::functiontargets and coroutine frames also used the heap without an explicit evaluation lifetime.Language and semantic changes
if/elif/else,try/catch,select,and,or, and//any,all,first,last,isempty,nth,limit,skip, andrangearitiesto_entries, and objectmapLazy ownership and allocation
evaluation_contextroutes coroutine frames and allocator-aware values through bounded storagetake()retains within the selected context;persist()detaches escaping values to heap storagesmallfunnodes instead of recursivestd::functiontargetsstd::stable_sort's hidden allocatorVerification
The allocator-aware OSSIA conversion support used by the score addon is proposed separately in celtera/avendish#202.