Skip to content

rgw/iam: customer managed policy - #646

Open
ArbitCode wants to merge 8 commits into
ceph:masterfrom
ArbitCode:wip-raja-customer-managed-policy
Open

rgw/iam: customer managed policy#646
ArbitCode wants to merge 8 commits into
ceph:masterfrom
ArbitCode:wip-raja-customer-managed-policy

Conversation

@ArbitCode

@ArbitCode ArbitCode commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member 
s3tests_boto3/functional/test_iam.py::test_create_policy PASSED                                                                                                                                        [ 20%]
s3tests_boto3/functional/test_iam.py::test_create_duplicate_policy PASSED                                                                                                                              [ 40%]
s3tests_boto3/functional/test_iam.py::test_get_policy PASSED                                                                                                                                           [ 60%]
s3tests_boto3/functional/test_iam.py::test_delete_policy PASSED                                                                                                                                        [ 80%]
s3tests_boto3/functional/test_iam.py::test_delete_nonexistent_policy PASSED                                                                                                                            [100%]

@ArbitCode

ArbitCode commented May 6, 2025

Copy link
Copy Markdown
Member Author

ceph/ceph#62401

cbodley
cbodley reviewed May 6, 2025
View reviewed changes

@cbodley cbodley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start 👍

Comment thread s3tests/functional/test_iam.py
Comment on lines +1489 to +1490
# Cleanup
iam_root.delete_policy(PolicyArn=policy['Policy']['Arn'])

@cbodley cbodley May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we support iam:ListPolicies, we can add a nuke_policies() to the iam_root/iam_alt_root fixtures in iam.py so that test cases don't have to handle cleanup on their own

Comment thread pytest.ini Outdated
user_policy
versioning
webidentity_test
policy

@cbodley cbodley May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call this managed_policy?

@ArbitCode ArbitCode May 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbodley overall related to this SPIKE can we call managed_policy instead of policy or customer_managed_policy ?

but there is other existing features related managed_policy in will that create any confusion?
rgw_rest_user_policy.cc

@ArbitCode ArbitCode May 12, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but AWS presents it as policy while create, delete, get etc

pritha-srivastava
pritha-srivastava reviewed May 7, 2025
View reviewed changes
Comment thread s3tests/functional/test_iam.py

@pytest.mark.policy
@pytest.mark.iam_account
def test_get_policy(iam_root):

@pritha-srivastava pritha-srivastava May 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add a get test for a non existent policy.

@ArbitCode ArbitCode self-assigned this Jun 28, 2025
@ArbitCode
ArbitCode force-pushed the wip-raja-customer-managed-policy branch from a76efd7 to cad408c Compare September 8, 2026 12:15
@ArbitCode ArbitCode added the DNM Do Not Merge label Sep 8, 2026
@ArbitCode
rgw/iam:CURD managed policy
d7f6de8 
Signed-off-by: Raja Sharma <raja@ibm.com>
@ArbitCode
ArbitCode force-pushed the wip-raja-customer-managed-policy branch from cad408c to fa1cbf4 Compare September 8, 2026 16:40
@ArbitCode
rgw/iam list managed policies
6ce5e52 
Signed-off-by: Raja Sharma <raja@ibm.com>
@ArbitCode
rgw/iam curd managed policy versions
66109ce 
Signed-off-by: Raja Sharma <raja@ibm.com>
@ArbitCode
ArbitCode force-pushed the wip-raja-customer-managed-policy branch from fa1cbf4 to 66109ce Compare September 9, 2026 06:47
@ArbitCode
rgw/iam curd managed policy tags
821abdc 
Signed-off-by: Raja Sharma <raja@ibm.com>
@ArbitCode
rgw/iam attach managed policy to user group and role
03329ed 
Signed-off-by: Raja Sharma <raja@ibm.com>
@ArbitCode
rgw/iam detach managed policy from user group and role
289cc0f 
Signed-off-by: Raja Sharma <raja@ibm.com>
@ArbitCode
rgw/iam list attached user group and role managed policies
6003b35 
Signed-off-by: Raja Sharma <raja@ibm.com>
@ArbitCode
rgw/iam list entities for policy
83f3cd8 
Signed-off-by: Raja Sharma <raja@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley left review comments
@pritha-srivastava pritha-srivastava pritha-srivastava left review comments
@dang dang Awaiting requested review from dang
@mattbenjamin mattbenjamin Awaiting requested review from mattbenjamin

At least 1 approving review is required to merge this pull request.

Assignees

@ArbitCode ArbitCode

Labels

DNM Do Not Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArbitCode @cbodley @pritha-srivastava