ENT-10199: Fixed a bug where some functions would not understand current namespace#6213
Open
SimonThalvorsen wants to merge 1 commit into
Open
ENT-10199: Fixed a bug where some functions would not understand current namespace#6213SimonThalvorsen wants to merge 1 commit into
SimonThalvorsen wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ent namespace Ticket: ENT-10199 Changelog: Title Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14098/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14098/ |
Member
|
In your commit message I think it would be nice to enumerate the functions for which this is now fixed. |
Member
Also, functions is a bit vague, i assume it means policy functions (not internal C functions). |
olehermanse
requested changes
Jul 3, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Please look into the NULL scope / bundle, and also improve the changelog entry.
| rval = ExpandPrivateRval(ctx, NULL, NULL, rp->val.item, rp->val.type); | ||
| const Bundle *caller_bundle = fp->caller ? PromiseGetBundle(fp->caller) : NULL; | ||
| const char *caller_ns = caller_bundle ? caller_bundle->ns : NULL; | ||
| rval = ExpandPrivateRval(ctx, caller_ns, NULL, rp->val.item, rp->val.type); |
Member
There was a problem hiding this comment.
Why is scope / bundle NULL here? If that is indeed correct, it deserves a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-10199
Changelog: Title