Don't advertise federation host with empty SSH fingerprint#3183
Open
larsewi wants to merge 1 commit into
Open
Conversation
If ssh-keyscan returns no host key, the setup status was still written with an empty transport_ssh_server_fingerprint. Superhubs then rendered an empty known_hosts entry for the host and the rsync pull later failed with "Host key verification failed". Gate the status update on a non-empty fingerprint and retry on subsequent runs. Changelog: Don't advertise federation host with empty SSH fingerprint Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
added
the
cherry-pick?
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14044/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14044/ |
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14076/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14076/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ssh-keyscan localhostreturns nothing (e.g. sshd not yet reachable), the feeder still wrote its setup status with an emptytransport_ssh_server_fingerprint. Superhubs then rendered an emptyknown_hostsentry and the rsync pull failed with "Host key verification failed". Gate the status write on a non-empty fingerprint and retry on later runs.