Cleanup strategy query building#121
Merged
Merged
Conversation
Contributor
|
It would be nice to add a snapshot of the built query, so that changes show up in PRs. opsqueue/opsqueue/src/consumer/strategy.rs Line 327 in e888930 |
Contributor
Author
|
@OpsBotPrime merge! |
Contributor
|
Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command |
Contributor
Author
|
@OpsBotPrime merge on Friday! |
Contributor
|
Rebased as 6587233, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Contributor
|
The build failed ❌. If this is the result of a flaky test, then tag me again with the |
Contributor
Author
|
@OpsBotPrime merge on Friday! |
Approved-by: ReinierMaas Priority: Normal Auto-deploy: false
Contributor
|
Rebased as a599549, waiting for CI … |
Contributor
|
CI job 🟡 started. |
OpsBotPrime
force-pushed
the
reinier/cleanup-strategy
branch
from
f7b8b4c to
a599549
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During our investigation into the
PreferDistinctquery building phase we came up with a simplification to the pattern.