Ability to add KeyBindings using a ConfigMap (FS approach)#753
Closed
RomanNikitenko wants to merge 2 commits into
Closed
Ability to add KeyBindings using a ConfigMap (FS approach)#753RomanNikitenko wants to merge 2 commits into
RomanNikitenko wants to merge 2 commits into
Conversation
…p provides keybindings.json Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Contributor
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
Contributor
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-753-amd64 |
RomanNikitenko
changed the title
Collaborator
Author
|
closing it in favor of #754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
keybindings.jsonfrom thevscode-editor-configurationsConfigMap,validates it as a JSON array, merges with existing keybindings on disk,
and writes to
/checode/remote/data/User/keybindings.jsonkeybindings.jsonfrom the ConfigMap exists override the default profile'skeybindingsResourceto use vscodeRemote scheme pointing to/checode/remote/data/User/keybindings.jsonWhat issues does this PR fix?
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder