feat: add gzip pre-compression for static assets to improve load time#761
Draft
RomanNikitenko wants to merge 1 commit into
Draft
feat: add gzip pre-compression for static assets to improve load time#761RomanNikitenko wants to merge 1 commit into
RomanNikitenko wants to merge 1 commit into
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Contributor
Contributor
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
21 tasks
Contributor
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-761-amd64 |
Collaborator
|
I'm not seeing a huge improvement in speed, but there's definitely less data being transferred. It might make a difference on slower connections. Before
After
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
.gzfiles directly when client supportsAccept-Encoding: gzip.gzis missing or on any errorCODE_DISABLE_STATIC_GZIP=1env variable as kill switchExpected improvement:
workbench.jstransfer drops from ~16MB to ~4.4MB: (~3.7x reduction),.gzfiles don't exist or env variable is set, the server behaves exactly as beforeWhat issues does this PR fix?
https://redhat.atlassian.net/browse/CRW-10327
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folderAssisted-by: Cursor AI