Honesty c: SHAPE_DROP_KEYS on shaped emit (0.19.5) - #150
Merged
Conversation
SHAPE_DROP_KEYS strips hid / _memnet_hid / elementId from GQL emit and jsonl. RSV errors no longer print hid. Nickname id stays off pin_map. Co-authored-by: chouswei <chouswei@users.noreply.github.com>
Keep SHAPE_DROP_KEYS import isort-clean so CI format check passes. Co-authored-by: chouswei <chouswei@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honesty
caudit of the MemNet hot path after #148 (nickname offpin_map) and #147 (observable rank). Same usage method on 0.19 — nob, no claima, no 0.20, no 1.0, norag_query.Leaks found
DROP_KEYSwas not a real strip.#148saidDROP_KEYS={id,hid}on wire text, butwire.pyhas no drop set and_emit_propswould printhid/_memnet_hid/elementIdif those keys sat onRecord.fields(cabinet leftover / poison). Nicknameidwas already off shaped read viainclude_nickname=False.id {_elN} already held…/mutate reserved id {_elN}). Pin-map## Reservesdid not list held ids.Happy-path
pin_map/ export / find after#148did not print_elNwhen identity lived only onRecord.hid.Cut (Hatch 0.19.5)
SHAPE_DROP_KEYS = {hid, _memnet_hid, elementId}inmemnet.models, applied in GQL_emit_propsand jsonl.idstays off shaped read only (mutate ack may still echo anidthe agent wrote).anchor=+llm_idonly.elementId.docs/operations/honesty-c-wire-audit.md.Surfaces checked
pin_map/ outline / CueConflict / findexport_pin_mappin_map/findJSONstdout_elN. Nickname echo only if the agent wroteid.hidexclude + field drop.elementIdadded to exclude set._memnet_hidMERGEAllowed leftovers (not bugs)
match_nicknamelookup by nickname.query walk@WALK:still uses endpoint hids (named leftover, not goldfish).read list/query contextpipe@TAG.Tests
tests/test_honesty_c_wire.pyplus existing identity / rank / export / peak_l / outline / façade tests.operatorCountstays 2. Caps stay hard. Do not dump (S).