test: cover the tui lifecycle and theme switching - #23
Merged
Merged
Conversation
Drive the real tui export with a fake host API and node:test mock timers to lock down startup, gentle override, not-ready/failed retries, missing-theme warning, solar mode, and abort/dispose cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds
test/tui.test.ts, which tests thetuifunction itself: timers, lifecycle and theme switching. Until now only the pure helpers had tests. The tests call the realtuiexport with a fake host API andnode:testmock timers (Date,setInterval,setTimeout). No source changes.16 tests covering the rules the plugin relies on:
toast: falsetheme.set()fails: retried on the next interval, the period isn't marked as handledCloses #
Behavior impact
periodFor, boundaries, gentle override)dayTheme,nightTheme,dayStartHour,nightStartHour,checkIntervalMs,toast) — README options table updatedpackage.jsonexports,files, published contents)Testing
npm run typecheckpasses (TypeScript 7.0.2)npm testpasses (38 tests)Also:
TZset to UTC, Pacific/Kiritimati, America/St_Johns and Australia/Lord_Howetuimakes at least one test fail. The guards are the abort listener,onDispose, the aborted-at-start check, the boundary-only check, not-ready/failed not marking the period handled, the ready retry and its single-pending guard, and thetry/catch.npm pack --dry-runis unchanged (tests aren't published)Checklist
(enforced by the PR Title check; drives the release-please version bump)