fix(contact-verification): pass analytics param in PhoneVerificationViewModel tests#1079
Merged
Merged
Conversation
github-actions
Bot
added
type: fix
…iewModel tests The phone verification funnel analytics change (#1076) added a required `analytics: FlipcashAnalyticsService` constructor parameter to PhoneVerificationViewModel, but the unit tests were not updated, breaking compilation of :apps:flipcash:features:contact-verification:compileDebugUnitTestKotlin on code/cash. Pass a relaxed mock in both test factories.
bmc08gt
force-pushed
the
fix/phone-verification-test-analytics-param
branch
from
a9ee640 to
38e5fe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
code/cashis red because:apps:flipcash:features:contact-verification:compileDebugUnitTestKotlinfails to compile:The phone verification funnel analytics work (#1076) added a required
analytics: FlipcashAnalyticsServiceconstructor parameter toPhoneVerificationViewModel, but the two unit-test factories that construct the view model were never updated. Because the analytics PR and the failing PR (#1077) landed independently, neither surfaced the break until both were oncode/cash.Fix
Pass a relaxed mock (
mockk(relaxed = true)) foranalyticsin both test factories. No production code changes.Testing