Skip to content

fix(account-settings): Prevent TypeError in YAML editor from missing ace-builds ext-prompt - #4109

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/gazebo-16se-ace-prompt-error
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/gazebo-16se-ace-prompt-error

Conversation

@sentry

@sentry sentry Bot commented Sep 6, 2026

Copy link
Copy Markdown

Description

This PR addresses GAZEBO-16SE, fixing a TypeError: Cannot read properties of undefined (reading 'prompt') that occurred in the YAML editor within account settings.

Code Example

Notable Changes

The root cause was identified as the AceEditor attempting to dynamically load ace/ext/prompt at runtime. Since ext-prompt was not statically imported in YamlEditor.tsx, and AceEditor's basePath was unset, the SPA router would incorrectly return index.html instead of the required JavaScript module. This resulted in an undefined module, leading to the TypeError.

The fix involves adding a static import for ace-builds/src-noconflict/ext-prompt in YamlEditor.tsx. This ensures the necessary extension is bundled and available, preventing the failed dynamic fetch and resolving the runtime error.

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes GAZEBO-16SE

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@sentry

sentry Bot commented Sep 6, 2026

Copy link
Copy Markdown
Author

⚠️ Seer needs additional GitHub permissions

Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix.

Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5144 1 5143 1
View the top 1 failed test(s) by shortest run time
src/pages/RepoPage/ConfigTab/tabs/YamlTab/YAML/YAML.test.jsx > src/pages/RepoPage/ConfigTab/tabs/YamlTab/YAML/YAML.test.jsx
Stack Traces | 0s run time
ReferenceError: ace is not defined
 ❯ Object.<anonymous> .../ace-builds/src-noconflict/ext-prompt.js:1:1

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 130.41kB (1.11%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.88MB 65.03kB (1.12%) ⬆️
gazebo-production-esm 5.96MB 65.38kB (1.11%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/YamlEditor-legacy.*.js 65.03kB 578.07kB 12.68% ⚠️

Files in assets/YamlEditor-legacy.*.js:

  • ./src/pages/AccountSettings/tabs/YAML/YamlEditor/YamlEditor.tsx → Total Size: 461 bytes
view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/YamlEditor.*.js 65.38kB 581.48kB 12.67% ⚠️

Files in assets/YamlEditor.*.js:

  • ./src/pages/AccountSettings/tabs/YAML/YamlEditor/YamlEditor.tsx → Total Size: 447 bytes

@codecov-public-qa

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5144 1 5143 1
View the top 1 failed test(s) by shortest run time
src/pages/RepoPage/ConfigTab/tabs/YamlTab/YAML/YAML.test.jsx > src/pages/RepoPage/ConfigTab/tabs/YamlTab/YAML/YAML.test.jsx
Stack Traces | 0s run time
ReferenceError: ace is not definedObject.<anonymous> .../ace-builds/src-noconflict/ext-prompt.js:1:1

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-releaser

Copy link
Copy Markdown
Collaborator

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
903337b Sun, 06 Sep 2026 10:51:11 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant