Skip to content

fix(yaml-editor): Add missing ace ext-searchbox import - #4110

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/gazebo-16tg-yaml-editor-search-VKglZB
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/gazebo-16tg-yaml-editor-search-VKglZB

Conversation

@sentry

@sentry sentry Bot commented Sep 6, 2026

Copy link
Copy Markdown

Description

This PR addresses GAZEBO-16TG by adding a static import for ace-builds/src-noconflict/ext-searchbox in src/pages/AccountSettings/tabs/YAML/YamlEditor/YamlEditor.tsx.

Previously, when a user triggered the search functionality in the YAML editor, ace would attempt to dynamically load the ext-searchbox module. However, due to an unset basePath, this dynamic load would fail, resulting in an undefined module. This led to a TypeError: Cannot read properties of undefined (reading 'Search') when e.Search(editor) was called.

By statically importing ext-searchbox, the module is bundled with the application, ensuring it is always available and preventing the runtime error.

Code Example

// src/pages/AccountSettings/tabs/YAML/YamlEditor/YamlEditor.tsx
import 'ace-builds/src-noconflict/ext-searchbox';

Notable Changes

  • Statically imports ace-builds/src-noconflict/ext-searchbox in src/pages/AccountSettings/tabs/YAML/YamlEditor/YamlEditor.tsx.
  • Resolves TypeError: Cannot read properties of undefined (reading 'Search') when using the search functionality in the YAML editor.
  • Ensures the ext-searchbox module is always available at runtime.

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes GAZEBO-16TG

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 26.69kB (0.23%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.83MB 13.32kB (0.23%) ⬆️
gazebo-production-esm 5.91MB 13.37kB (0.23%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/YamlEditor.*.js 13.37kB 529.48kB 2.59%

Files in assets/YamlEditor.*.js:

  • ./src/pages/AccountSettings/tabs/YAML/YamlEditor/YamlEditor.tsx → Total Size: 447 bytes
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/YamlEditor-legacy.*.js 13.32kB 526.35kB 2.6%

Files in assets/YamlEditor-legacy.*.js:

  • ./src/pages/AccountSettings/tabs/YAML/YamlEditor/YamlEditor.tsx → Total Size: 461 bytes

@sentry

sentry Bot commented Sep 6, 2026

Copy link
Copy Markdown
Author

⚠️ Seer needs additional GitHub permissions

Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix.

Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
5746 2 5744 3
View the top 2 failed test(s) by shortest run time
src/pages/AccountSettings/tabs/YAML/YAML.test.jsx > src/pages/AccountSettings/tabs/YAML/YAML.test.jsx
Stack Traces | 0s run time
ReferenceError: ace is not defined
 ❯ Object.<anonymous> .../ace-builds/src-noconflict/ext-searchbox.js:1:1
src/pages/RepoPage/ConfigTab/tabs/YamlTab/YAML/YAML.test.jsx > src/pages/RepoPage/ConfigTab/tabs/YamlTab/YAML/YAML.test.jsx
Stack Traces | 0s run time
ReferenceError: ace is not defined
 ❯ Object.<anonymous> .../ace-builds/src-noconflict/ext-searchbox.js:1:1

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-public-qa

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4282 1 4281 2
View the top 1 failed test(s) by shortest run time
src/pages/AccountSettings/tabs/YAML/YAML.test.jsx > src/pages/AccountSettings/tabs/YAML/YAML.test.jsx
Stack Traces | 0s run time
ReferenceError: ace is not definedObject.<anonymous> .../ace-builds/src-noconflict/ext-searchbox.js:1:1

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-releaser

Copy link
Copy Markdown
Collaborator

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
dbbe6ee Sun, 06 Sep 2026 10:50:49 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant