fix(browser): Guard ResizeObserver for older Safari versions - #4113
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 71 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4113 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15150 +3
Branches 4387 4390 +3
==========================================
+ Hits 14961 14963 +2
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Harness.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4113 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15150 +3
Branches 4387 4381 -6
==========================================
+ Hits 14961 14963 +2
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #4113 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15150 +3
Branches 4379 4390 +11
==========================================
+ Hits 14961 14963 +2
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4113 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15150 +3
Branches 4387 4381 -6
==========================================
+ Hits 14961 14963 +2
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
1 participant
Description
This PR addresses a
ReferenceError: Can't find variable: ResizeObserveroccurring on iOS 12 / Safari 12 when navigating to commit detail pages.The root cause was the unconditional instantiation of
ResizeObserverwithin theuseTruncationhook.ResizeObserveris not supported in Safari versions prior to 13.1.Code Example
Notable Changes
The fix involves adding a
typeof ResizeObserver !== 'undefined'check before instantiatingResizeObserver. IfResizeObserveris not available,nullis returned, allowing theuseTruncationhook to degrade gracefully without crashing the application. This ensures that users on older browsers can still access the page, albeit without the truncation functionality.Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes GAZEBO-186P
This PR was automatically generated by Sentry. You can adjust this setting at any time.